Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast on empty wasmvm cache metric setup (backport #1576) #1580

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 28, 2023

This is an automatic backport of pull request #1576 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from alpe as a code owner August 28, 2023 12:51
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1580 (7560319) into releases/v0.3x (390fda7) will increase coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.3x    #1580      +/-   ##
==================================================
+ Coverage           57.96%   58.15%   +0.19%     
==================================================
  Files                  57       57              
  Lines                7603     7605       +2     
==================================================
+ Hits                 4407     4423      +16     
+ Misses               2885     2869      -16     
- Partials              311      313       +2     
Files Changed Coverage Δ
x/wasm/keeper/metrics.go 50.00% <0.00%> (+50.00%) ⬆️

... and 2 files with indirect coverage changes

@alpe alpe merged commit 4643ce9 into releases/v0.3x Aug 31, 2023
7 of 8 checks passed
@alpe alpe deleted the mergify/bp/releases/v0.3x/pr-1576 branch August 31, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant