Skip to content

Commit

Permalink
Merge pull request #512 from CosmWasm/builders-0018
Browse files Browse the repository at this point in the history
Finalize builders 0018
  • Loading branch information
webmaster128 committed Jan 30, 2024
2 parents 401557b + 6dd292e commit 7170ab1
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
13 changes: 6 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
docker:
# The audit tool might use a more modern Rust version than the build jobs. See
# "Tooling Rust compiler" in docs/COMPILER_VERSIONS.md
- image: cimg/rust:1.70.0
- image: cimg/rust:1.75.0
steps:
- checkout
- run:
Expand All @@ -152,8 +152,8 @@ jobs:
command: rustc --version; cargo --version; rustup --version
- restore_cache:
keys:
- cargocache-v3-libwasmvm_audit-rust:1.70.0-{{ checksum "libwasmvm/Cargo.lock" }}
- cargocache-v3-libwasmvm_audit-rust:1.70.0-
- v3-libwasmvm_audit-rust:1.75.0-{{ checksum "libwasmvm/Cargo.lock" }}
- v3-libwasmvm_audit-rust:1.75.0-
- run:
name: Install cargo-audit
command: cargo install --debug cargo-audit --version 0.17.6
Expand All @@ -164,7 +164,7 @@ jobs:
- save_cache:
paths:
- ~/.cargo/registry
key: cargocache-v3-libwasmvm_audit-rust:1.70.0-{{ checksum "libwasmvm/Cargo.lock" }}
key: v3-libwasmvm_audit-rust:1.75.0-{{ checksum "libwasmvm/Cargo.lock" }}

format-go:
docker:
Expand Down Expand Up @@ -389,9 +389,8 @@ jobs:
mkdir artifacts
# Static (from build)
# TODO: Change this line to libwasmvm_muslc.x86_64.a when upgrading to builders 0018+
cp ./internal/api/libwasmvm_muslc.a artifacts/libwasmvm_muslc.x86_64.a
cp ./internal/api/libwasmvm_muslc.aarch64.a artifacts/libwasmvm_muslc.aarch64.a
cp ./internal/api/libwasmvm_muslc.x86_64.a artifacts/
cp ./internal/api/libwasmvm_muslc.aarch64.a artifacts/
cp ./internal/api/libwasmvmstatic_darwin.a artifacts/
# Shared (from git)
Expand Down
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.PHONY: all build build-rust build-go test

# Builds the Rust library libwasmvm
BUILDERS_PREFIX := cosmwasm/go-ext-builder:0017
BUILDERS_PREFIX := cosmwasm/go-ext-builder:0018
# Contains a full Go dev environment including CGO support in order to run Go tests on the built shared library
# This image is currently not published.
ALPINE_TESTER := cosmwasm/alpine-tester:local
Expand Down Expand Up @@ -77,8 +77,7 @@ release-build-alpine:
rm -rf libwasmvm/target/x86_64-unknown-linux-musl/release
# build the muslc *.a file
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-alpine
# TODO: Change this line to libwasmvm_muslc.x86_64.a when upgrading to builders 0018+
cp libwasmvm/artifacts/libwasmvm_muslc.a internal/api
cp libwasmvm/artifacts/libwasmvm_muslc.x86_64.a internal/api
cp libwasmvm/artifacts/libwasmvm_muslc.aarch64.a internal/api
make update-bindings

Expand Down
2 changes: 1 addition & 1 deletion builders/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Versioned by a simple counter that is not bound to a specific CosmWasm version
# See builders/README.md
BUILDERS_PREFIX := cosmwasm/go-ext-builder:0017
BUILDERS_PREFIX := cosmwasm/go-ext-builder:0018

.PHONY: docker-image-centos7
docker-image-centos7:
Expand Down
2 changes: 2 additions & 0 deletions builders/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ versions of the builder images.

**Unreleased**

**Version 0018:**

- Remove Go dev environment from `cosmwasm/go-ext-builder:XXXX-alpine`
- Write x86_64 muslc output in `libwasmvm_muslc.x86_64.a` instead of
`libwasmvm_muslc.a`
Expand Down
2 changes: 1 addition & 1 deletion docs/COMPILER_VERSIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ We currently use the following version:
| ------------------------ | ------------ | --------------------------------- |
| Production Rust compiler | 1.73.0 | Builders version 0017 |
| Min Rust compiler | 1.70.0 | Supports builder versions >= 0017 |
| Tooling Rust compiler | 1.70.0 | |
| Tooling Rust compiler | 1.75.0 | |

0 comments on commit 7170ab1

Please sign in to comment.