Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity around GoIter creation; bump min Go version to 1.21 #478

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

webmaster128
Copy link
Member

No description provided.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree that partially initializing on the Rust side, then finishing on the Go side seems a bit confusing.

@webmaster128 webmaster128 changed the title Improve readability and clarity around GoIter creation Improve clarity around GoIter creation; bum pin Go version to 1.21 Nov 27, 2023
@webmaster128 webmaster128 changed the title Improve clarity around GoIter creation; bum pin Go version to 1.21 Improve clarity around GoIter creation; bump min Go version to 1.21 Nov 27, 2023
@webmaster128 webmaster128 force-pushed the GoIter-creation branch 2 times, most recently from 7a0a55a to 843b2f4 Compare November 28, 2023 09:49
@webmaster128 webmaster128 merged commit 589ea5a into main Nov 29, 2023
14 checks passed
@webmaster128 webmaster128 deleted the GoIter-creation branch November 29, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants