Improve vtables code #482
Merged
Improve vtables code #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
improve-vtables
branch
from
8be414f
to
d9b822c
Compare
chipshort
approved these changes
Nov 29, 2023
| *mut UnmanagedVector, // result output | ||
| *mut UnmanagedVector, // error message output | ||
| ) -> i32, | ||
| pub query_external: Option< |
|
For the record, I am not really conviced that "vtable" is the best term here. Those are pretty much static function pointers that are the same functions for all instances. The functions itself are stored a Go module level variables, making them pretty much fixed per process. I was thinking about a more global approach getting the pointers from Go to Rust, but it would open all sorts of ordering questions. Since I don't think there is much to gain, I gave up the global approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.