Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VM.Create #491

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Remove VM.Create #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3903ef
Remove VM.Create
webmaster128 Jan 10, 2024
a4e53ce
Start MIGRATING.md
webmaster128 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/MIGRATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Migrating docs for callers of the wasmvm Go project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
We'll have to add a few more entries here (in a separate PR). For example the gas multiplier reduction

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wanted to take the opportunity to create a place for those things.


## 1.x -> 2.0

- `VM.Create` was removed. Use `VM.StoreCode` instead.
5 changes: 0 additions & 5 deletions lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ func (vm *VM) Cleanup() {
api.ReleaseCache(vm.cache)
}

// Deprecated: Renamed to StoreCode
func (vm *VM) Create(code WasmCode) (Checksum, error) {
return vm.StoreCode(code)
}

// StoreCode will compile the Wasm code, and store the resulting compiled module
// as well as the original code. Both can be referenced later via Checksum.
// This must be done one time for given code, after which it can be
Expand Down