Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Callbacks #520

Merged
merged 10 commits into from
Jun 26, 2024
Merged

IBC Callbacks #520

merged 10 commits into from
Jun 26, 2024

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Feb 23, 2024

also known as ADR-8

This just adds the necessary types and entrypoints.

@chipshort chipshort force-pushed the ibc-callbacks branch 3 times, most recently from 2cc6707 to 65f7c45 Compare April 5, 2024 15:07
@chipshort chipshort added this to the 2.1.0 milestone Apr 9, 2024
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

types/ibc.go Outdated Show resolved Hide resolved
@chipshort chipshort force-pushed the ibc-callbacks branch 2 times, most recently from 3d99f8b to 59b9f2e Compare April 23, 2024 11:21
@chipshort chipshort marked this pull request as ready for review June 26, 2024 09:14
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But could you remove all those build library commits? Maybe create a new branch and cherry-pick the code changes?

@chipshort chipshort merged commit 15d29dc into main Jun 26, 2024
13 of 14 checks passed
@chipshort chipshort deleted the ibc-callbacks branch June 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants