Customizable limits #560
Merged
Customizable limits #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
co/customizable-limits
branch
3 times, most recently
from
8ac0326
to
a2d2de5
Compare
aumetra
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
This feature adds a big value to usability of cosmwasm. Also it's simplifies the configuration related code. I left some comments in this PR, but I realized that they should be addressed earlier in the cosmwasm PR. Since there was no final release of 2.2.0, we still have some room to discuss those comments and decide if they have any point from the user point of view. Overall I like it!
chipshort
force-pushed
the
co/customizable-limits
branch
from
a2d2de5
to
8d3938d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #559