Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt of GitHub actions #89

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheKodeToad
Copy link

@TheKodeToad TheKodeToad commented Apr 11, 2023

Just changed the template to Java 17 and act on all branches.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023

CLA assistant check
All committers have signed the CLA.

@TheKodeToad
Copy link
Author

😭 lol

@TheKodeToad
Copy link
Author

TheKodeToad commented Apr 11, 2023

Well there's a nice badge but I'm pretty sure it's meaningless in this case! (I didn't actually mean to agree because I'm pretty sure I can't until I'm older)

@valoeghese
Copy link
Member

valoeghese commented May 20, 2023

We kinda need that signed to accept a PR, so I guess we'll pretend that you're old enough to sign a CLA 🥴

@TheKodeToad
Copy link
Author

As I said I did by mistake :p

@TheKodeToad
Copy link
Author

Why do people keep deleting their comments? 😭

I'm confused

@eyezahhhh
Copy link
Member

What's happening with this? Do we want actions for this codebase?

@valoeghese
Copy link
Member

valoeghese commented Sep 26, 2023

I can't merge without their legal signing of the CLA. Given she has declared she can't legally sign it and it's null and void, I'm not sure about merging this.

@TheKodeToad
Copy link
Author

Only one year to go :D

@eyezahhhh
Copy link
Member

We can wait

@TheKodeToad
Copy link
Author

🤣

@valoeghese
Copy link
Member

valoeghese commented Oct 24, 2023

Another issue actually, is our 1.16.5 branch should be Java 8
though we still need to wait a year to legally merge without funny legal consequences 😆

@TheKodeToad
Copy link
Author

Signed it again. Regarding Java 8, you should probably just change the Java version if you merge this into the 1.16 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants