Skip to content

Implement ForceInclude Attribute #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement ForceInclude Attribute #225

wants to merge 1 commit into from

Conversation

Guillermo-Santos
Copy link

@Guillermo-Santos Guillermo-Santos commented Nov 23, 2024 •
edited
Loading

To use this you will need to add the ForceInclude attribute to the GCImplementation and Vtable types.

This have 2 downsides:

  1. Increment compile time.
  2. It doesn't handle generics, so if you try to use the attribute on a class with public Generic methods or on a generic method itself, then IL2CPU would probably throw

@Guillermo-Santos
Implement ForceInclude Attribute
9700ea8 
Implemented ForceInclude Attribute Scanning.
@Guillermo-Santos
Copy link
Author

This solve #195

@valentinbreiz valentinbreiz self-requested a review November 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinbreiz valentinbreiz valentinbreiz approved these changes

@MishaProductions MishaProductions MishaProductions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guillermo-Santos @valentinbreiz @MishaProductions