Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR2 fixes #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PSR2 fixes #3

wants to merge 1 commit into from

Conversation

valerianpereira
Copy link

PSR2 compatible

@valerianpereira
Copy link
Author

@Flyingmana seems to be some trouble with composer and not related to the PR.
Could you please check this at once?

@Flyingmana
Copy link

sorry, it did still use a non https url for firegento, this is fixed now. Please pull from master again.

Also, is it part of PSR2 that implements and extends on classes are not allowed to be on own lines? hurts a bit the readability in some cases

valerianpereira
valerianpereira commented Mar 10, 2018
View reviewed changes
Copy link
Author

@valerianpereira valerianpereira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flyingmana any specific file, you referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valerianpereira @Flyingmana