Merge pull request #207 from couchbaselabs/1.1.1_bugfixes

fixes in the named parameter dialog
Couchbase-Ecosystem · May 27, 2024 · bd094d7 · bd094d7
2 parents 71e578c + 744a40f
commit bd094d7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/.idea/codeStyles/codeStyleConfig.xml b/.idea/codeStyles/codeStyleConfig.xml
diff --git a/src/main/java/com/couchbase/intellij/workbench/NamedParameterDialog.java b/src/main/java/com/couchbase/intellij/workbench/NamedParameterDialog.java
@@ -26,6 +26,7 @@
 import java.awt.event.MouseEvent;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.TreeMap;
 
 public class NamedParameterDialog extends DialogWrapper {
     private final DefaultListModel<String> listModel = new DefaultListModel<>();
@@ -39,8 +40,8 @@ public class NamedParameterDialog extends DialogWrapper {
     private final EditorEx editor;
     private final EditorEx editorBuiltIn;
     private final Map<String, String> editorContentMap = new HashMap<>();
+    private final JLabel errorLabel;
     private Map<String, String> projectNamedParams;
-    private JLabel errorLabel;
 
 
     protected NamedParameterDialog(Project project) {
@@ -142,7 +143,12 @@ public void actionPerformed(ActionEvent e) {
                 String selectedValue = list.getSelectedValue();
                 if (selectedValue != null) {
                     NamedParams params = NamedParamsStorage.getInstance().getValue();
-                    String content = params.getParams().getOrDefault(selectedValue, "");
+                    String content;
+                    if (editorContentMap.containsKey(selectedValue)) {
+                        content = editorContentMap.get(selectedValue);
+                    } else {
+                        content = params.getParams().getOrDefault(selectedValue, "");
+                    }
                     ApplicationManager.getApplication().runWriteAction(() -> editor.getDocument().setText(content));
                     editor.setViewer(false);
                 } else {
@@ -153,20 +159,26 @@ public void actionPerformed(ActionEvent e) {
         });
 
         NamedParams params = NamedParamsStorage.getInstance().getValue();
-        params.getParams().forEach((key, value) -> addItem(key));
+        TreeMap<String, String> sortedMap = new TreeMap<>(params.getParams());
+        sortedMap.forEach((key, value) -> addItem(key));
 
         try {
             projectNamedParams = NamedParametersUtil.readProjectNamedParameters(project);
+            TreeMap<String, String> treeMap = new TreeMap<>(projectNamedParams);
 
-            for (String name : projectNamedParams.keySet()) {
+            for (String name : treeMap.keySet()) {
                 builtinListModel.addElement(name);
             }
 
             builtinList.addListSelectionListener(evt -> {
                 if (!evt.getValueIsAdjusting()) {
                     JBList list = (JBList) evt.getSource();
                     if (list.getSelectedIndex() != -1) {
-                        ApplicationManager.getApplication().runWriteAction(() -> editorBuiltIn.getDocument().setText(projectNamedParams.get(list.getSelectedValue().toString())));
+                        ApplicationManager.getApplication().runWriteAction(() -> {
+
+                            editorBuiltIn.getDocument().setText(projectNamedParams.get(list.getSelectedValue().toString()));
+
+                        });
                     }
                 }
             });