InfoSec Page and Replacement of undraw images #577
Conversation
✅ Deploy Preview for practical-hodgkin-4543e2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Should the logo on the About Us page be moved to the right? For the Info Sec page is there a rough idea of what should be on it? I checked the Figma and didn't see a page for it. |
src/components/Navbar/Navbar.js
Outdated
| @@ -37,6 +37,7 @@ const NavBar = () => { | |||
| {/* when hackathon will return to active it again no need to delete */} | |||
| {/* <ActiveListItem url='/hackathons' name='Hackathons' /> */} | |||
| <ActiveListItem url='/contactus' name='Contact Us' /> | |||
| <ActiveListItem url='/InfoSec' name='InfoSec' /> | |||
There was a problem hiding this comment.
url should be /infosec to be consistent with current style
There was a problem hiding this comment.
info sec should be before contact us in the navbar.
src/pages/InfoSec/InfoSec.js
Outdated
| const meta = { | ||
| title: 'Info-Sec', | ||
| desc: 'Learn more about CougarCS Web-Dev', | ||
| url: 'https://cougarcs.com/web-dev', |
There was a problem hiding this comment.
change to be accurate to current site.
desc: 'Learn more about CougarCS Info-sec'
url: 'https://cougarcs.com/infosec'
src/App.js
Outdated
| @@ -43,6 +44,7 @@ const App = () => { | |||
| <Route path='/gallery/:event' element={<GalleryEvent />} /> | |||
| <Route path='/404' element={<NotFound />} /> | |||
| <Route path='*' element={<FourOFour />} /> | |||
| <Route path='/InfoSec' element={<InfoSec />} /> | |||
There was a problem hiding this comment.
move route between tutoring and gallery/event
src/pages/InfoSec/InfoSec.js
Outdated
| <h1>InfoSec at CougarCS</h1> | ||
| <p className='lead-text'> | ||
| Information Security something maybe put team members below not | ||
| to sure what the vision is here |
There was a problem hiding this comment.
look at webdev/tutoring for help on making this page to look better.
Discord button should link to info sec discord.
|
Kudos, SonarCloud Quality Gate passed!
|
What type of PR is this? (check all applicable)
Description
This PR adds an InfoSec page and replaces the undraw images with more fitting pictures.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?