Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revised webdev page #578

Merged
merged 2 commits into from
Nov 5, 2023
Merged

revised webdev page #578

merged 2 commits into from
Nov 5, 2023

Conversation

derekcfop
Copy link
Contributor

@derekcfop derekcfop commented Nov 2, 2023

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

added all suggestions by brody

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Mobile & Desktop Screenshots/Recordings

Screenshot from 2023-11-01 23-28-02

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for practical-hodgkin-4543e2 ready!

Name Link
🔨 Latest commit 9c4dc38
🔍 Latest deploy log https://app.netlify.com/sites/practical-hodgkin-4543e2/deploys/6547bb49100a1a00070826bb
😎 Deploy Preview https://deploy-preview-578--practical-hodgkin-4543e2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Brodypen Brodypen self-requested a review November 5, 2023 15:44
Copy link

sonarqubecloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Brodypen Brodypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deploy forked branch next time

Good work !

@Brodypen Brodypen merged commit 6553e41 into CougarCS:master Nov 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants