Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CSS Fixes #1503

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Jai0212
Copy link
Contributor

@Jai0212 Jai0212 commented Jan 23, 2025

Proposed Changes

Fixed minor CSS issues in the UI to make it look better:

  • No padding around course modal
  • "and", "or" in the graph were not centered inside the ellipse
  • FCE Count component's down arrow was outside the purple button

Here are the updated UI changes:

Screenshot 2025-01-22 at 8 11 18 PM

Screenshot 2025-01-22 at 7 04 26 PM.

Screenshot 2025-01-22 at 7 02 42 PM

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

To center the"and" and "or" I used translate with a hardcoded value and it seemed to look good based on various screen sizes. If required, I can look into a dynamic way of doing this.
Additionally, the timetable part of the course modal does not have padding when downward scrolling is possible. I can fix that also if required.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2b2a214a-afd0-49b6-bc7b-d4ce6b324341

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.914%

Totals Coverage Status
Change from base Build ce5c17ea-cece-46d1-92d7-5375535065b7: 0.0%
Covered Lines: 533
Relevant Lines: 1137

💛 - Coveralls

@Jai0212 Jai0212 requested a review from david-yz-liu January 23, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants