Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect missing translation #94

Open
henrytao-me opened this issue Jun 4, 2020 · 2 comments
Open

Detect missing translation #94

henrytao-me opened this issue Jun 4, 2020 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@henrytao-me
Copy link
Member

What

We have multiple languages now and they could be out of sync pretty quickly. Ex: new string is added en.json but missing in other languages. We need a way to identify new changes and resolves it somehow.

@henrytao-me henrytao-me added the help wanted Extra attention is needed label Jun 4, 2020
@henrytao-me henrytao-me self-assigned this Jun 5, 2020
@ChrisDryden
Copy link

ChrisDryden commented Jun 21, 2020

Was looking at doing this, but was curious if there was a specific way you wanted this integrated in the build process. I have a quick script that just diffs the keys and sub-keys, but I was wondering if this needs to be added to the ci? Could this just be a standalone script in the translations folder?

Edit:
Doing more looking into the way that we generate translations through quilt it appears that the best way to do this would be to do the key diffing in javascript in this file so the warnings of translation differences will show whenever someone compiles. I am working on this now.

@henrytao-me
Copy link
Member Author

Right. I was thinking same thing. Thanks @ChrisDryden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants