git ignore translations file and run on commands instead #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytao-me
reviewed
Jun 5, 2020
owencraston
approved these changes
Jun 12, 2020
|
Close in favor of #93 (comment) and #94 (comment) |
|
@henrytao-me wouldn't we still want this in addition to the watch script? I think running the watch script would be beneficial if someone is actively editing the translations (like jest --watch) but for regular development flow we don't want to require the watch script to be running, right? |
henrytao-me
reviewed
Jun 22, 2020
There was a problem hiding this comment.
@jordanAtShopify Sorry about closing the PR. Can you reopen it and update the README? We can ship this 🙇
henrytao-me
force-pushed
the
translations-build-step
branch
from
a6780a8
to
d55032f
Compare
henrytao-me
approved these changes
Jun 24, 2020
…eld/mobile into translations-build-step
|
CI is failing. Can you fix it too? @jordanAtShopify https://github.com/CovidShield/mobile/runs/803431283 |
|
@henrytao-me I fixed it on master |
lpcox
pushed a commit
to covidsafe/CovidShieldExposure
that referenced
this pull request
Jul 7, 2020
…-step git ignore translations file and run on commands instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help avoid conflicts and make sure translations are in sync when developing.