Fix accessibility in carousel #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering this is a cherry-pick in downstream repo. I will merge it for now and fix forward if necessary. |
|
@henrytao-me This works well. It'd be great if when moving from one page to the next focus would shift to he header. Otherwise the user needs to navigate backward which is awkward. #12 for more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick cds-snc/covid-alert-app#496 and https://github.com/cds-snc/covid-shield-mobile/pull/392/files
It also fixes auto focus accessibility in Text component
Expected result:
Accessibility is scoped to page, not screen. That means when accessibility is on, user cannot swipe to next screen. They need to press next button.