Add accessibility props for external buttons #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svinkle
reviewed
May 28, 2020
| onPress={onSymptomps} | ||
| text={i18n.translate('Info.CheckSymptoms')} | ||
| icon="icon-external-arrow" | ||
| accessibilityRole="link" |
There was a problem hiding this comment.
Missing accessibleLabel here. Otherwise only the accessibilityHint text will be announced.
|
@jordanAtShopify This is looking good. The Privacy links might need to be in another PR due to #40. |
svinkle
approved these changes
Jun 2, 2020
lpcox
pushed a commit
to covidsafe/CovidShieldExposure
that referenced
this pull request
Jul 7, 2020
…ssibility Add accessibility props for external buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #49 (Privacy policy still to do)
This adds proper accessibility props to external link buttons.