Enable landscape orientation for android #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbearben
commented
May 28, 2020
Comment on lines
+61
to
+65
| useEffect(() => { | ||
| bottomSheetRef.current?.snapTo(isExpanded ? 0 : 1); | ||
| }, [width, isExpanded]); |
There was a problem hiding this comment.
This isn't ideal - unfortunately without it when the bottom sheet is collapsed, on rotation it sometimes would disappear.
sbearben
commented
May 30, 2020
| import {useOrientation} from './useOrientation'; | ||
| import {Theme} from './theme'; | ||
|
|
||
| export const useMaxContentWidth = (): number | undefined => { |
There was a problem hiding this comment.
Rationale for this hook is that if we later want to change how the maxWidth is determined (say, maybe percentage of viewport), we can just make the modification here.
jordanAtShopify
approved these changes
Jun 3, 2020
lpcox
pushed a commit
to covidsafe/CovidShieldExposure
that referenced
this pull request
Jul 7, 2020
Enable landscape orientation for android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #11
screenOrientationin the manifest fromportraittounspecifiedDimensionsobject have been changed to use theuseWindowDimensionshook in order to be dynamicBottomSheet was tricky - when using percent snapPoints the
BottomSheetRawcomponent doesn't seem to update its internal height/width values that it uses to evaluate the points based on percent when screen dimensions change (see this issue for related discussion: osdnk/react-native-reanimated-bottom-sheet#72).Tried getting around this by passing it a
keythat changed on rotation in order to force remount, but this had other issues that needed working around and offers poor UX. In the end opted for passing in dynamic values as snap points, based on current width/height of the viewport.Edit: Did not see the recent design updates here: #11 (comment). Feel free to close if this doesn't go deep enough.
Home:
Onboarding:
