Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F.call: 매개변수 전달(Parameter passing) 번역 최신화 #168

Merged
merged 30 commits into from
May 7, 2024

Conversation

jabdong4ny
Copy link
Contributor

@jabdong4ny jabdong4ny commented Mar 10, 2024

#167 F.call: 매개변수 전달(Parameter passing) 번역 최신화

@twoo0220
Copy link
Member

특별히 수정해야될 부분 없어보입니다.
@luncliff 님 추가확인 부탁드리겠습니다.

@twoo0220 twoo0220 requested a review from luncliff March 14, 2024 12:55
Copy link
Member

@luncliff luncliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫번째 기여를 환영합니다. 아래의 제안들을 한번 검토해주시길 부탁드립니다. 👍 👍

sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
@utilForever
Copy link
Member

@jabdong4ny @luncliff 님의 리뷰를 반영하고 나시면 저에게 노티해주세요. 2차 리뷰 진행하겠습니다.

@utilForever utilForever self-requested a review March 18, 2024 15:00
jabdong4ny and others added 7 commits March 19, 2024 09:20
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
@jabdong4ny
Copy link
Contributor Author

@jabdong4ny @luncliff 님의 리뷰를 반영하고 나시면 저에게 노티해주세요. 2차 리뷰 진행하겠습니다.

@luncliff 님 comment 확인하였습니다. 2차 리뷰 부탁드립니다.

sections/Functions.md Outdated Show resolved Hide resolved
jabdong4ny and others added 4 commits March 20, 2024 01:02
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단히 살펴봤습니다. 확인 후 수정 부탁드립니다.

sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
sections/Functions.md Outdated Show resolved Hide resolved
jabdong4ny and others added 5 commits April 1, 2024 08:47
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
jabdong4ny and others added 11 commits April 1, 2024 08:59
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Chris Ohk <utilForever@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
Co-authored-by: Park DongHa <luncliff@gmail.com>
@luncliff luncliff requested a review from a team May 7, 2024 14:49
Copy link
Member

@luncliff luncliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#168 (comment) 의 내용이 반영되어, Resolved 상태라고 생각됩니다.

Assignee인 @twoo0220 님께서 병합해주시면 될 것 같습니다.

Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 너무 늦게 확인했네요. 기여해주셔서 감사합니다. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants