Fix build error by moving SD.h/FS.h includes to implementation file#15
Merged
Fix build error by moving SD.h/FS.h includes to implementation file#15
Conversation
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix syntax error in card processing function
Fix build error by moving SD.h/FS.h includes to implementation file
Dec 26, 2025
Crashkeyz
approved these changes
Dec 26, 2025
Crashkeyz
approved these changes
Dec 26, 2025
Crashkeyz
approved these changes
Dec 26, 2025
Crashkeyz
approved these changes
Dec 26, 2025
Crashkeyz
approved these changes
Dec 29, 2025
Crashkeyz
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions build failing due to
SD.handFS.hincludes in header file causing compilation issues across translation units.Changes
drivers/cardputer_adv_driver.h: Removed#include <SD.h>and#include <FS.h>, kept only forward declarations. Includes remain in.cppfile..github/workflows/build-firmware.yml: Added CI workflow for firmware builds with:m5stack-cardputertargetif-no-files-found: warnfor optional bootloader/partitionspermissions: contents: readWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.registry.nm1.platformio.org/home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer(dns block)/home/REDACTED/.local/bin/pio pio platform install espressif32(dns block)api.registry.platformio.org/home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer(dns block)/home/REDACTED/.local/bin/pio pio platform install espressif32(dns block)collector.platformio.org/home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer(dns block)/home/REDACTED/.local/bin/pio pio platform install espressif32(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.