Skip to content

Fix build error by moving SD.h/FS.h includes to implementation file#15

Merged
Crashkeyz merged 4 commits intomainfrom
copilot/debug-syntax-error
Dec 26, 2025
Merged

Fix build error by moving SD.h/FS.h includes to implementation file#15
Crashkeyz merged 4 commits intomainfrom
copilot/debug-syntax-error

Conversation

Copy link
Contributor

Copilot AI commented Dec 26, 2025

GitHub Actions build failing due to SD.h and FS.h includes in header file causing compilation issues across translation units.

Changes

  • drivers/cardputer_adv_driver.h: Removed #include <SD.h> and #include <FS.h>, kept only forward declarations. Includes remain in .cpp file.

  • .github/workflows/build-firmware.yml: Added CI workflow for firmware builds with:

    • PlatformIO build for m5stack-cardputer target
    • Artifact uploads with if-no-files-found: warn for optional bootloader/partitions
    • Explicit permissions: contents: read
 #ifndef CARDPUTER_ADV_DRIVER_H
 #define CARDPUTER_ADV_DRIVER_H
 
-#include <SD.h>
-#include <FS.h>
-
+// Forward declarations - actual includes in .cpp file
 void initialize_driver();
 bool initialize_sd_card();

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.registry.nm1.platformio.org
    • Triggering command: /home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer (dns block)
    • Triggering command: /home/REDACTED/.local/bin/pio pio platform install espressif32 (dns block)
  • api.registry.platformio.org
    • Triggering command: /home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer (dns block)
    • Triggering command: /home/REDACTED/.local/bin/pio pio platform install espressif32 (dns block)
  • collector.platformio.org
    • Triggering command: /home/REDACTED/.local/bin/pio pio run -e m5stack-cardputer (dns block)
    • Triggering command: /home/REDACTED/.local/bin/pio pio platform install espressif32 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

https://github.com/Crashkeyz/UltimatumCardputerKey/actions/runs/20522655400/job/58962419118#step:6:1


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits December 26, 2025 13:58
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Co-authored-by: Crashkeyz <186653592+Crashkeyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix syntax error in card processing function Fix build error by moving SD.h/FS.h includes to implementation file Dec 26, 2025
Copilot AI requested a review from Crashkeyz December 26, 2025 14:02
@Crashkeyz Crashkeyz marked this pull request as ready for review December 26, 2025 18:04
@Crashkeyz Crashkeyz merged commit 2348c26 into main Dec 26, 2025
0 of 2 checks passed
@Crashkeyz Crashkeyz self-requested a review December 26, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants