adjustments in for preparation for hpcm/ngi providers #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
init()
functions tomain.go
by making each package'sinit()
public (Init()
) so they can be run in a specific orderRegisterProviderCommand
to add provider versions of eachcomand as a subcommand to cani's command. this currently requires the
passing of a provider name for all calls but easily allows for each
provider to define their own settings and not clash with each other
utils.CloneCommand()
funciton to clone a cobra command, whichproviders can use to create and modify the commands as needed
recommendations.Print()
method to a provider-specificmethod:
root.D.PrintRecommendations(cmd, args, recommendations)
bootstrapCmd
tocaniCmd
to betterdistinguish cani vs. provider
cmd
package and into the
csm
package where it belongsprovider.ProviderCommands
interface for allcurrently-supported commands
csm
, which will begin to adjust tests formultiple providers
DEBUG
statements toTRACE
since development willbe minimal on CSM and less of that info is relevant to multiple
providers
cmd.Name()
conditionals tocmd.Parent().Name()
since the provider command is a sub command
makeprovider
command for changes (some stupid changes, butthey meet the immediate need)
Risks and Mitigations