Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/google/adk/cli/adk_web_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,9 @@ def _setup_telemetry(
# TODO - remove the else branch here once maybe_set_otel_providers is no
# longer experimental.
if otel_to_cloud:
_setup_gcp_telemetry_experimental(internal_exporters=internal_exporters)
_setup_gcp_telemetry(internal_exporters=internal_exporters)
elif _otel_env_vars_enabled():
_setup_telemetry_from_env_experimental(
internal_exporters=internal_exporters
)
_setup_telemetry_from_env(internal_exporters=internal_exporters)
else:
# Old logic - to be removed when above leaves experimental.
tracer_provider = TracerProvider()
Expand All @@ -339,7 +337,7 @@ def _otel_env_vars_enabled() -> bool:
])


def _setup_gcp_telemetry_experimental(
def _setup_gcp_telemetry(
internal_exporters: list[SpanProcessor] = None,
):
if typing.TYPE_CHECKING:
Expand Down Expand Up @@ -381,7 +379,7 @@ def _setup_gcp_telemetry_experimental(
_setup_instrumentation_lib_if_installed()


def _setup_telemetry_from_env_experimental(
def _setup_telemetry_from_env(
internal_exporters: list[SpanProcessor] = None,
):
from ..telemetry.setup import maybe_set_otel_providers
Expand Down Expand Up @@ -669,8 +667,8 @@ def get_fast_api_app(
tear_down_observer: Callback for cleaning up the file system observer.
register_processors: Callback for additional Span processors to be added
to the TracerProvider.
otel_to_cloud: EXPERIMENTAL. Whether to enable Cloud Trace
and Cloud Logging integrations.
otel_to_cloud: Whether to enable Cloud Trace and Cloud Logging
integrations.

Returns:
A FastAPI app instance.
Expand Down
2 changes: 1 addition & 1 deletion src/google/adk/cli/cli_tools_click.py
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ def decorator(func):
show_default=True,
default=False,
help=(
"EXPERIMENTAL Optional. Whether to write OTel data to Google Cloud"
"Optional. Whether to write OTel data to Google Cloud"
" Observability services - Cloud Trace and Cloud Logging."
),
)
Expand Down
2 changes: 0 additions & 2 deletions src/google/adk/telemetry/google_cloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
from opentelemetry.sdk.trace import SpanProcessor
from opentelemetry.sdk.trace.export import BatchSpanProcessor

from ..utils.feature_decorator import experimental
from .setup import OTelHooks

if TYPE_CHECKING:
Expand All @@ -42,7 +41,6 @@
_DEFAULT_LOG_NAME = 'adk-otel'


@experimental
def get_gcp_exporters(
enable_cloud_tracing: bool = False,
enable_cloud_metrics: bool = False,
Expand Down
3 changes: 0 additions & 3 deletions src/google/adk/telemetry/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import BatchSpanProcessor

from ..utils.feature_decorator import experimental


@dataclass
class OTelHooks:
Expand All @@ -47,7 +45,6 @@ class OTelHooks:
log_record_processors: list[LogRecordProcessor] = field(default_factory=list)


@experimental()
def maybe_set_otel_providers(
otel_hooks_to_setup: list[OTelHooks] = None,
otel_resource: Optional[Resource] = None,
Expand Down
Loading