[pull] main from Kilo-Org:main #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…466) Cherry-picked from RooCodeInc/Roo-Code commit f2276bebc4 Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
…icate (ROO-410) When users approve tool execution with feedback text, the feedback was being pushed as a separate tool_result before the actual tool executed and pushed its own result. This created duplicate tool_results with the same tool_use_id, violating the Anthropic API protocol (GitHub #10465). Changes: - Add approvalFeedback storage to hold feedback until tool completes - Modify pushToolResult to merge stored feedback into the tool's actual result - Update askApproval to store feedback instead of pushing as separate result - Apply fix to both MCP tools and regular tools, native and XML protocols - Update validateToolResultIds comments to clarify deduplication is now safety net Cherry-picked from RooCodeInc/Roo-Code commit e4e67e27dc9c8b1e8f70a0bbd56d70ebcbf887f3 (#10519)
…n Zod v4 (#5173) Fixes DTS build errors introduced in PR #5107 where z.function() was used with incorrect Zod v4 syntax. ## Problem PR #5107 upgraded core-schemas to Zod v4 and used z.function({ input, output }) syntax, but this is incorrect for Zod v4: - In Zod v4, z.function() is a function factory, not a schema - It cannot be used inside z.object() - This causes DTS build errors: "Object literal may only specify known properties, but 'input' does not exist" See: - Zod v4 changelog: https://zod.dev/v4/changelog#zfunction - Official workaround: colinhacks/zod#4143 ## Solution Use z.custom<T>() with runtime validator for function types: - pollFn: z.custom<() => Promise<unknown>>((val) => typeof val === "function") - onProgress: z.custom<(current: number, total: number) => void>((val) => typeof val === "function") This approach: - Fixes DTS build errors - Preserves type inference - Adds runtime function validation (following Zod best practices) cc #5107 Co-authored-by: Marius <marius@kilocode.ai>
Remove deprecated zai-glm-4.6 model from Cerebras provider
Pull in Roo tool calling fixes (PRs 10466 & 10519)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )