Remove defer from material.min.js #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding defer would allow this script to execute after the `getmdl-select.js` script. For me the problem was that I was setting the data-selected=true, but in the `setSelectedItem` function it was requesting dropdown.MaterialTextField, which was not there yet because the `material.min.js` did not execute yet.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I ran into an issue when using your library, which will probably be solved by just changing this in the README.md
I do not have the most experience with JavaScript and asynchronous loading, so this might be solvable in a different way.
Explanation of the problem:
Adding defer would allow this script to execute after the
getmdl-select.jsscript. For me the problem was that I was setting the
data-selected=true, but in the
setSelectedItemfunction it wasrequesting dropdown.MaterialTextField, which was not there yet because
the
material.min.jsdid not execute yet.