Fix Proposal for #9214 #9399
Open
Fix Proposal for #9214 #9399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoidLeech
added
pr type: fix
|
Same comment as here |
|
Thanks, i didn't know that about keywords. Fixes #9214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links can be attached to contraptions in chains, causing trees of dependencies of the order they need to be deleted when the contraption is assembled. This change makes so the information of that dependency (the insertion order to the HashMap) is not lost by using a LinkedHashMap, and it is used to remove the blocks in the proper order by inverting that LinkedHashMap before the iterations. This fixes #9214.
It's a proposal cose I only used data structures of "java.util.". Any HashMap that guarantees that the iteration order will be the insertion one and it can be iterated in reverse would be a nice candidate, even if its a custom one.