Skip to content

Comments

test: Object Mapper로 인한 테스트 오류 수정 / #61#65

Merged
JayongLee merged 2 commits intomainfrom
refactor/#61
Dec 6, 2025
Merged

test: Object Mapper로 인한 테스트 오류 수정 / #61#65
JayongLee merged 2 commits intomainfrom
refactor/#61

Conversation

@JayongLee
Copy link
Member

🗞️ 연관된 이슈

🔥 이슈번호

✅ 작업 내용

  • Object Mapper로 인한 테스트 오류 수정

📸 스크린샷 (선택)

체크리스트 ✅

  • 코드가 정상적으로 컴파일되나요?
  • merge할 브랜치의 위치를 확인했나요?
  • 테스트 코드를 작성하셨나요?

기타

@JayongLee JayongLee self-assigned this Dec 6, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @JayongLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 ObjectMapper 사용으로 인해 발생했던 테스트 오류를 수정합니다. RedisOAuth2AuthorizationServiceTest에서 AuthorizationRedisRepository를 초기화할 때 ObjectMapper를 올바르게 구성하여 전달함으로써, Redis에 객체를 저장하고 불러오는 과정에서 발생할 수 있는 직렬화/역직렬화 문제를 해결하고 테스트의 안정성을 확보합니다.

Highlights

  • ObjectMapper 의존성 추가: 테스트 클래스 RedisOAuth2AuthorizationServiceTestcom.fasterxml.jackson.databind.ObjectMapper를 임포트했습니다.
  • AuthorizationRedisRepository 초기화 수정: 테스트 설정(setUp 메서드)에서 AuthorizationRedisRepository를 초기화할 때 ObjectMapper 인스턴스를 생성하고 findAndRegisterModules()를 호출한 후, 이를 생성자에 전달하도록 변경하여 객체 매핑 관련 테스트 오류를 해결했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 ObjectMapperAuthorizationRedisRepository 생성자에 주입하여 테스트 오류를 수정합니다. 변경 사항은 올바르며, 이로 인해 발생하는 테스트 실패를 해결할 것으로 보입니다. 코드 품질 및 테스트 성능 개선을 위해 한 가지 제안 사항을 남겼습니다. ObjectMapper는 생성 비용이 높은 객체이므로, 테스트 클래스 내에서 static final 필드로 만들어 재사용하는 것이 좋습니다.

@JayongLee JayongLee merged commit c1d2aea into main Dec 6, 2025
1 check passed
@JayongLee JayongLee deleted the refactor/#61 branch December 6, 2025 04:12
JayongLee added a commit that referenced this pull request Dec 6, 2025
# Conflicts:
#	src/test/java/org/creditto/authserver/client/service/RedisOAuth2AuthorizationServiceTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant