Skip to content

Comments

refactor: remittance 목록 조회 API의 userId 전달 방식을 PathVariable로 통일#113

Merged
Yang-Chaeyeon merged 1 commit intomainfrom
refactor/#109
Dec 3, 2025
Merged

refactor: remittance 목록 조회 API의 userId 전달 방식을 PathVariable로 통일#113
Yang-Chaeyeon merged 1 commit intomainfrom
refactor/#109

Conversation

@Yang-Chaeyeon
Copy link
Collaborator

@Yang-Chaeyeon Yang-Chaeyeon commented Dec 3, 2025

🗞️ 연관된 이슈

🔥 이슈번호

✅ 작업 내용

  • remittance 목록 조회 API의 userId 전달 방식을 PathVariable로 통일

📸 스크린샷 (선택)

체크리스트 ✅

  • 코드가 정상적으로 컴파일되나요?
  • merge할 브랜치의 위치를 확인했나요?
  • 테스트 코드를 작성하셨나요?

기타

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Yang-Chaeyeon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 송금 목록 조회 API에서 사용자 ID를 전달하는 방식을 RequestParam에서 PathVariable로 통일하여 API 디자인의 일관성을 높이는 것을 목표로 합니다. 이는 리소스 식별에 PathVariable을 사용하는 일반적인 RESTful API 설계 원칙을 따릅니다.

Highlights

  • API 엔드포인트 변경: 송금 목록 조회 API에서 사용자 ID를 전달하는 방식이 RequestParam에서 PathVariable로 변경되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 송금 목록 조회 API의 userId 전달 방식을 @RequestParam에서 @PathVariable로 변경하여 API의 일관성을 높인 좋은 리팩토링입니다. RESTful API 설계 원칙에도 더 잘 부합하게 되었습니다. API의 경로가 변경되었으므로 관련 테스트 코드(통합 테스트 등)도 함께 수정되었는지 확인이 필요해 보입니다. PR에 테스트 관련 파일이 포함되어 있지 않아 확인이 어려웠지만, 변경된 API가 올바르게 동작하는지 보장하기 위해 테스트 코드를 업데이트하는 것이 중요합니다. 전반적으로 좋은 변경이라고 생각합니다. 수고하셨습니다.

@Yang-Chaeyeon Yang-Chaeyeon merged commit b12959e into main Dec 3, 2025
1 check passed
@Yang-Chaeyeon Yang-Chaeyeon deleted the refactor/#109 branch December 6, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant