Skip to content

Comments

test: RedissonClient Mocking / #133#134

Merged
JayongLee merged 1 commit intomainfrom
test/#133
Feb 23, 2026
Merged

test: RedissonClient Mocking / #133#134
JayongLee merged 1 commit intomainfrom
test/#133

Conversation

@JayongLee
Copy link
Member

@JayongLee JayongLee commented Feb 23, 2026

🗞️ 연관된 이슈

🔥 이슈번호

✅ 작업 내용

  • Test에서 RedissonClient Mocking

📸 스크린샷 (선택)

체크리스트 ✅

  • 코드가 정상적으로 컴파일되나요?
  • merge할 브랜치의 위치를 확인했나요?
  • 테스트 코드를 작성하셨나요?

기타

@JayongLee JayongLee linked an issue Feb 23, 2026 that may be closed by this pull request
2 tasks
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JayongLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the test suite by implementing RedissonClient mocking across several test files. By using @MockitoBean, the tests can now run without requiring an actual Redisson instance, leading to faster execution and more reliable, isolated unit and integration tests. This change addresses issue #133.

Highlights

  • Test Infrastructure Improvement: Introduced mocking for the RedissonClient dependency in various test classes using @MockitoBean to enhance test isolation and performance.
Changelog
  • src/test/java/org/creditto/core_banking/CoreBankingApplicationTests.java
    • Added @MockitoBean for RedissonClient.
  • src/test/java/org/creditto/core_banking/domain/exchange/controller/ExchangeControllerTest.java
    • Added @MockitoBean for RedissonClient.
  • src/test/java/org/creditto/core_banking/domain/regularremittance/service/RegularRemittanceServiceTest.java
    • Added @MockitoBean for RedissonClient.
    • Removed a trailing newline character at the end of the file.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces RedissonClient mocking in several test classes. This is a good practice for isolating unit tests and preventing external dependencies from affecting test results. The changes are straightforward and correctly apply the @MockitoBean annotation to mock the RedissonClient.

@JayongLee JayongLee merged commit fa1b957 into main Feb 23, 2026
1 check passed
@JayongLee JayongLee deleted the test/#133 branch February 23, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: 레디스 모킹을 통한 테스트 실패 해결

1 participant