Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pull Request] Refactored network related parts. #19

Merged
merged 16 commits into from
Apr 23, 2023
Merged

[Pull Request] Refactored network related parts. #19

merged 16 commits into from
Apr 23, 2023

Conversation

Dynesshely
Copy link
Member

What does this PR do?

Features:

  • Added interfaces to control servers and clients easily.

Refactorings:

  • Departed DevicesServer into DevicesServer and DevicesClient.
  • Move UDP pard into DevicesDiscoveryServer.cs as single module.

Related issues

@Dynesshely
💾 Feat(Interfaces): Init basic interfaces for network and module cont…
a6dd859 
…roller.
@Dynesshely
💾 Feat(TasksManager): Added RunTask and RunTaskAsync methods to e…
12f2404 
…xecute codes with better log.
@Dynesshely
🧩 Refactor(DevicesNetwork): Move UDP parts to `DevicesDiscoveryServer…
2bfdea2 
….cs` and `NetworkHelper.cs`.
@Dynesshely
🔧 Fix: Udp part of DevicesNetwork moved to new class.
4b36f0a
@Dynesshely
💾 Feat(DevicesDiscoveryServer): Added status support.
981807d
@Dynesshely
🧩 Refactor(Network): Better WebManager usage.
d249c62
@Dynesshely
💾 Feat(Interfaces): Require OnReceive function.
ad1790b
@Dynesshely
💾 Feat(Interfaces): IKitXClient requires Send and OnReceive fun…
a0df74d 
…ctions.
@Dynesshely
🧩 📦 Refactor, Struct: Rename Server folder to Network folder.
88e3077
@Dynesshely
💾 Feat(Network): Init DevicesClient.cs file.
6586add
@Dynesshely
💾 Feat(Interfaces.Network): OnReceive callback supports length, and…
648dce2 
… run synchronizly.
@Dynesshely
🧩 Refactor(Network): Adapt to updated interfaces.
1580bd7
@Dynesshely
🧩 Refactor(Network): Made PluginsServer adapted to new interface.
5dc99b9
@Dynesshely
📄 Docs(Network): Docs for enums in Status.cs.
f3f4bfb
@Dynesshely
🧩 Refactor(Network): Depart client part in devices network to `Device…
a68ecee 
…sClient.cs`
@Dynesshely
💾 Feat: Updated call site.
48d906f
@Dynesshely Dynesshely added the enhancement New feature or request label Apr 23, 2023
@Dynesshely Dynesshely requested a review from Cronyet April 23, 2023 17:02
Cronyet
Cronyet approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@Cronyet Cronyet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a68ecee

Two parts leads to better control.

Cronyet
Cronyet approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@Cronyet Cronyet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4b36f0a

As it should be!

@Dynesshely Dynesshely merged commit 8dfb603 into dev=main Apr 23, 2023
Dynesshely added a commit that referenced this pull request Apr 23, 2023
@Dynesshely
💾 Feat: Merge pull request #19 from Crequency/refactor=network-services
0a8e3e6 
[Pull Request] Refactored network related parts.
@Cronyet Cronyet mentioned this pull request Apr 23, 2023
Closed
@Dynesshely Dynesshely added the merged Pull Request had been merged label May 1, 2023
This was referenced May 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cronyet Cronyet Cronyet approved these changes

Assignees

@Dynesshely Dynesshely

@Cronyet Cronyet

Labels
enhancement New feature or request merged Pull Request had been merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dynesshely @Cronyet