C2DEVEL-13229: update to version 1.19#8
Open
CrocBomber wants to merge 44 commits intorelease-1.19from
Open
Conversation
AWS ResizeDisk method doesn't work with C2 cloud, because its EC2 API doesn't implement DescribeVolumesModifications method, which is used for detecting pending modifications. The resize functionality for C2 cloud was implemented in new method: ResizeDiskC2. It checks pending modifications via ModifyVolume API method. Now ResizeDiskC2 is used instead of ResizeDisk in all project (including tests).
Original and target sizes of C2 volumes must be divisible by 8. Test documentation updates: 1. fix commands for e2e test run: escape "[]" symbols 2. move resize test from "red" to "green" 3. remove duplicates from e2e tests list
CrocBomber
commented
Jun 5, 2023
| cs = f.ClientSet | ||
| var err error | ||
| snapshotrcs, err = restClient(testsuites.SnapshotAPIGroup, testsuites.APIVersionv1) | ||
| snapshotrcs, err = restClient(testsuites.SnapshotAPIGroup, testsuites.APIVersionv1beta1) |
Owner
Author
There was a problem hiding this comment.
Где-то проскакивал ворнинг
Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
| volumeID = disk.VolumeID | ||
| diskSize = fmt.Sprintf("%dGi", defaultDiskSize) | ||
| snapshotrcs, err = restClient(testsuites.SnapshotAPIGroup, testsuites.APIVersionv1) | ||
| snapshotrcs, err = restClient(testsuites.SnapshotAPIGroup, testsuites.APIVersionv1beta1) |
Comment on lines
+64
to
+65
| SnapshotAPIVersion = "snapshot.storage.k8s.io/v1beta1" | ||
| APIVersionv1beta1 = "v1beta1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
What testing is done?