fix: remove preview card

Crossbell-Box · Aug 23, 2022 · 5741534 · 5741534
1 parent 65ca253
commit 5741534
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 15 deletions.
diff --git a/components/common/Note/MarkdownRenderer.tsx b/components/common/Note/MarkdownRenderer.tsx
@@ -131,18 +131,7 @@ export function MarkdownRenderer({
 									);
 								},
 								a: function Link({ node, ...props }) {
-									const { data, isLoading, isSuccess } = useLinkPreview(
-										props.href
-									);
-									return isLoading ? (
-										<LinkPreviewSkeleton />
-									) : isSuccess &&
-									  data &&
-									  (("siteName" in data && data.siteName) ||
-											("title" in data && data.title) ||
-											("description" in data && data.description)) ? (
-										<LinkPreviewCard data={data} />
-									) : (
+									return (
 										<Text
 											size={fontSize}
 											variant="link"
@@ -158,6 +147,34 @@ export function MarkdownRenderer({
 											{props.children}
 										</Text>
 									);
+									// TODO: better UI
+									// const { data, isLoading, isSuccess } = useLinkPreview(
+									// 	props.href
+									// );
+									// return isLoading ? (
+									// 	<LinkPreviewSkeleton />
+									// ) : isSuccess &&
+									//   data &&
+									//   (("siteName" in data && data.siteName) ||
+									// 		("title" in data && data.title) ||
+									// 		("description" in data && data.description)) ? (
+									// 	<LinkPreviewCard data={data} />
+									// ) : (
+									// 	<Text
+									// 		size={fontSize}
+									// 		variant="link"
+									// 		component="a"
+									// 		href={props.href}
+									// 		target={
+									// 			props.href && isExternalUrl(props.href)
+									// 				? "_blank"
+									// 				: undefined
+									// 		}
+									// 		rel="noreferrer"
+									// 	>
+									// 		{props.children}
+									// 	</Text>
+									// );
 								},
 								table: ({ node, ...props }) => {
 									return (

diff --git a/components/layouts/AppLayout/MoreMenu.tsx b/components/layouts/AppLayout/MoreMenu.tsx
@@ -42,7 +42,7 @@ export default function MoreMenu() {
 
 				<Menu.Label>Ecosystem</Menu.Label>
 				<MenuItemLink href="https://crosssync.app/">CrossSync</MenuItemLink>
-				<MenuItemLink href="https://xlog.app/">Xlog</MenuItemLink>
+				<MenuItemLink href="https://xlog.app/">xlog</MenuItemLink>
 			</Menu.Dropdown>
 		</Menu>
 	);

diff --git a/components/ui/CharacterManagement.tsx b/components/ui/CharacterManagement.tsx
@@ -92,7 +92,7 @@ export default function CharacterManagement({
 				form.setFieldValue("handle", "");
 			}
 		}
-	}, [form, form.values.name, mode]);
+	}, [form.values.name, mode]);
 
 	// check if handle is taken
 	const [debouncedHandle] = useDebouncedValue(form.values.handle, 200);

diff --git a/components/ui/CharacterProfile.tsx b/components/ui/CharacterProfile.tsx
@@ -26,7 +26,6 @@ import {
 	composeCharacterFollowHref,
 	composeWalletCharacterEditHref,
 } from "@/utils/url";
-import { useRouter } from "next/router";
 import Link from "next/link";
 
 // used in character page to display the profile