Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix chromedriver start #868

Merged
merged 2 commits into from
Sep 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: fix chromedriver start
ChromeDriver changed its startup message from "ChromeDriver was started successfully." to "ChromeDriver was started successfully on port XXXXX."
Kelly Selden committed Sep 3, 2024

Verified

This commit was signed with the committer’s verified signature.
PHPirates Thomas Schouten
commit 8f43382f701ad2776a74af14890a87723be3d311
4 changes: 2 additions & 2 deletions packages/remote/src/index.js
Original file line number Diff line number Diff line change
@@ -193,13 +193,13 @@ async function spawnWebDriver(name, args) {

await driverSwitch(name, {
async chrome() {
await waitForText('ChromeDriver was started successfully.');
await waitForText('ChromeDriver was started successfully');
},
async firefox() {
await waitForText('Listening on 127.0.0.1');
},
async edge() {
await waitForText('Microsoft Edge WebDriver was started successfully.');
await waitForText('Microsoft Edge WebDriver was started successfully');
},
});