Skip to content

CI test #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Crowfunder merged 4 commits into from
Aug 3, 2025
Merged

CI test #8

Crowfunder merged 4 commits into from
Aug 3, 2025

Conversation

@nichitacebotari0
Copy link
Collaborator

@nichitacebotari0 nichitacebotari0 commented Apr 25, 2025 •
edited
Loading

  • test dont pass without resources and we dont commit the resources to the repo

@nichitacebotari0 nichitacebotari0 self-assigned this Apr 25, 2025
@Crowfunder
Copy link
Owner

Crowfunder commented Apr 25, 2025 •
edited
Loading

  • Create mock parseable xmls for tests, they should be included under resources/parseable folder
  • Change how ParserService behaves, it should load all parseables from path defined in application.yml, akin to how it works with PropertiesRepository, instead of loading only parseables listed in the application.yml

@nichitacebotari0 nichitacebotari0 force-pushed the ci-test branch 3 times, most recently from 975ef87 to bc7565a Compare May 18, 2025 20:04
@nichitacebotari0 nichitacebotari0 changed the title [WIP] CI test CI test May 18, 2025
@nichitacebotari0 nichitacebotari0 force-pushed the ci-test branch 2 times, most recently from 06f5a83 to 707e498 Compare May 27, 2025 20:22
@nichitacebotari0 nichitacebotari0 force-pushed the ci-test branch 5 times, most recently from 11a06b1 to 895389b Compare July 20, 2025 12:30
@nichitacebotari0
Copy link
Collaborator Author

nichitacebotari0 commented Jul 28, 2025

pushed rebase on latest main

Crowfunder
Crowfunder approved these changes Aug 3, 2025
View reviewed changes
Copy link
Owner

@Crowfunder Crowfunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Changes look good, as I pointed out in the conversation the derivedParameters update problem should be addressed, but in a separate issue/pr.
CI works so that's amazing. Thanks!

@Crowfunder Crowfunder merged commit eace500 into main Aug 3, 2025
1 check passed
@Crowfunder Crowfunder deleted the ci-test branch August 4, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Crowfunder Crowfunder Crowfunder approved these changes

Assignees

@nichitacebotari0 nichitacebotari0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nichitacebotari0 @Crowfunder