-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Recaptcha Enterprise #1128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
force-pushed
the
recaptcha-enterprise
branch
from
January 7, 2025 14:56
517e012
to
0a13f23
Compare
Plan is to go live on Tuesday 1/14 at 2pm. |
canac
reviewed
Jan 8, 2025
wrandall22
force-pushed
the
recaptcha-enterprise
branch
from
January 9, 2025 14:16
057c4e4
to
4464058
Compare
canac
reviewed
Jan 9, 2025
canac
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I see the Recaptcha token and action in the request in staging for regular checkout and branded checkout.
wrandall22
force-pushed
the
recaptcha-enterprise
branch
from
January 9, 2025 15:57
c1bb967
to
f27eb23
Compare
… pages that the action is not being run on
wrandall22
force-pushed
the
recaptcha-enterprise
branch
from
January 14, 2025 18:37
f27eb23
to
2dc3a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from Recaptcha v3 to Recaptcha Enterprise. The scoring has moved from an AEM API call to the Cortex Gateway, so we will not know it in real time, but on gift submission. We also changed the actions to match up to one pre-existing Google defined action and a similar wording for branded.