Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-1991 Switch to an event object for callbacks on the Dashboard #3011

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Jul 28, 2023

  • introduce a ToolCardEvent class to capture all the events that can come out of tool cards
  • introduce a DashboardHomeEvent to capture all the events HomeContent can emit
  • introduce a DashboardLessonsEvent that represents events that can happen in the Lessons layout
  • make the AllFavoritesList have a generic onEvent method
  • finish updating DashboardLayout to use event objects for callbacks

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #3011 (22d2ce0) into develop (e9dbab1) will decrease coverage by 0.29%.
Report is 13 commits behind head on develop.
The diff coverage is 1.67%.

@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
- Coverage    30.74%   30.46%   -0.29%     
===========================================
  Files          417      419       +2     
  Lines        10233    10318      +85     
  Branches      2240     2276      +36     
===========================================
- Hits          3146     3143       -3     
- Misses        6562     6652      +90     
+ Partials       525      523       -2     
Files Changed Coverage Δ
...org/cru/godtools/ui/dashboard/DashboardActivity.kt 46.15% <0.00%> (-3.85%) ⬇️
...u/godtools/ui/dashboard/home/AllFavoritesLayout.kt 0.00% <0.00%> (ø)
...n/org/cru/godtools/ui/dashboard/home/HomeLayout.kt 14.37% <0.00%> (+1.81%) ⬆️
...org/cru/godtools/ui/dashboard/tools/ToolsLayout.kt 21.95% <0.00%> (-1.74%) ⬇️
...g/cru/godtools/ui/tooldetails/ToolDetailsLayout.kt 13.12% <0.00%> (-0.26%) ⬇️
...otlin/org/cru/godtools/ui/tools/ToolCardActions.kt 0.00% <0.00%> (ø)
...otlin/org/cru/godtools/ui/tools/ToolCardLayouts.kt 0.00% <0.00%> (ø)
...n/org/cru/godtools/ui/dashboard/DashboardLayout.kt 40.00% <6.66%> (-9.47%) ⬇️
...cru/godtools/ui/dashboard/lessons/LessonsLayout.kt 33.33% <10.00%> (-6.67%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett merged commit 72fe049 into develop Aug 1, 2023
12 checks passed
@frett frett deleted the dashboardEvents branch August 1, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant