Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gt-2322 : Add two languages to forced name #3620

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

gyasistory
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 40.50%. Comparing base (252128c) to head (160c5b1).
Report is 4 commits behind head on develop.

Files Patch % Lines
...cru/godtools/ui/languages/LanguageName+Previews.kt 0.00% 8 Missing ⚠️
...tlin/org/cru/godtools/ui/languages/LanguageName.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3620      +/-   ##
===========================================
- Coverage    40.54%   40.50%   -0.05%     
===========================================
  Files          439      439              
  Lines        10850    10856       +6     
  Branches      2303     2301       -2     
===========================================
- Hits          4399     4397       -2     
- Misses        5772     5780       +8     
  Partials       679      679              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frett frett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed an adjacent bug that we should just fix in this PR

@gyasistory gyasistory requested a review from frett July 30, 2024 19:41
@gyasistory
Copy link
Contributor Author

noticed an adjacent bug that we should just fix in this PR

@frett was this what you commented about?

@gyasistory gyasistory merged commit 7a5dd91 into develop Jul 30, 2024
12 checks passed
@gyasistory gyasistory deleted the Gt-2322---Add-Two-languages-to-forced-Name branch July 30, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants