Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2200 add warning error if attempting login offline #3735

Merged

Conversation

gyasistory
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.85%. Comparing base (a01ada6) to head (df8aa8f).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...in/kotlin/org/cru/godtools/ui/login/LoginLayout.kt 0.00% 13 Missing ⚠️
...org/cru/godtools/account/GodToolsAccountManager.kt 40.00% 3 Missing ⚠️
...n/kotlin/org/cru/godtools/account/LoginResponse.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3735      +/-   ##
===========================================
- Coverage    38.89%   38.85%   -0.05%     
===========================================
  Files          446      446              
  Lines        11851    11866      +15     
  Branches      2610     2617       +7     
===========================================
+ Hits          4609     4610       +1     
- Misses        6463     6477      +14     
  Partials       779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from cdeafdb to aa85c3f Compare October 16, 2024 21:06
@gyasistory gyasistory requested a review from frett October 16, 2024 21:06
@gyasistory gyasistory marked this pull request as ready for review October 16, 2024 21:06
frett
frett previously requested changes Oct 16, 2024
Copy link
Contributor

@frett frett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jira ticket has updated text and trigger conditions for the error dialog. You need to update the PR to match what is specified there

@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from aa85c3f to 26ede8c Compare October 22, 2024 12:51
@gyasistory gyasistory requested a review from frett October 22, 2024 12:51
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from 26ede8c to c9f5618 Compare October 22, 2024 13:08
frett
frett previously requested changes Oct 22, 2024
Copy link
Contributor

@frett frett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

business logic in the view

@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from c9f5618 to 08ae432 Compare October 22, 2024 20:07
@gyasistory gyasistory requested a review from frett October 22, 2024 20:24
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from 08ae432 to 305401f Compare October 28, 2024 18:28
@gyasistory gyasistory requested a review from frett October 28, 2024 18:28
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch 3 times, most recently from 886e114 to c7197d7 Compare October 31, 2024 20:03
@gyasistory gyasistory requested a review from frett October 31, 2024 20:04
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from c7197d7 to a1b0200 Compare November 1, 2024 14:45
@gyasistory gyasistory requested a review from frett November 1, 2024 14:45
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch 2 times, most recently from cfc8e63 to d46d6aa Compare November 1, 2024 15:02
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch 2 times, most recently from 1c5e2c3 to b881a5e Compare November 4, 2024 19:51
@gyasistory gyasistory requested a review from frett November 4, 2024 19:59
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch 2 times, most recently from 0297079 to 64d28a4 Compare November 4, 2024 20:04
frett
frett previously requested changes Nov 4, 2024
Copy link
Contributor

@frett frett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just the 1 more change I think

@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from 64d28a4 to 2a22a56 Compare November 4, 2024 20:22
@gyasistory gyasistory requested a review from frett November 4, 2024 20:23
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from 2a22a56 to 2a29b0e Compare November 4, 2024 20:29
@gyasistory gyasistory force-pushed the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch from 2a29b0e to df8aa8f Compare November 4, 2024 20:39
@gyasistory gyasistory merged commit e2ddf59 into develop Nov 4, 2024
12 checks passed
@gyasistory gyasistory deleted the GT-2200-Add-Warning-error-if-attempting-Login-Offline branch November 4, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants