-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-2200 add warning error if attempting login offline #3735
GT-2200 add warning error if attempting login offline #3735
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3735 +/- ##
===========================================
- Coverage 38.89% 38.85% -0.05%
===========================================
Files 446 446
Lines 11851 11866 +15
Branches 2610 2617 +7
===========================================
+ Hits 4609 4610 +1
- Misses 6463 6477 +14
Partials 779 779 ☔ View full report in Codecov by Sentry. |
cdeafdb
to
aa85c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jira ticket has updated text and trigger conditions for the error dialog. You need to update the PR to match what is specified there
aa85c3f
to
26ede8c
Compare
26ede8c
to
c9f5618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
business logic in the view
c9f5618
to
08ae432
Compare
library/account/src/main/kotlin/org/cru/godtools/account/AccountModule.kt
Outdated
Show resolved
Hide resolved
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
08ae432
to
305401f
Compare
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
886e114
to
c7197d7
Compare
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
c7197d7
to
a1b0200
Compare
cfc8e63
to
d46d6aa
Compare
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
1c5e2c3
to
b881a5e
Compare
0297079
to
64d28a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just the 1 more change I think
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
64d28a4
to
2a22a56
Compare
library/account/src/main/kotlin/org/cru/godtools/account/GodToolsAccountManager.kt
Outdated
Show resolved
Hide resolved
2a22a56
to
2a29b0e
Compare
2a29b0e
to
df8aa8f
Compare
No description provided.