Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade godtools-shared #3736

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Upgrade godtools-shared #3736

wants to merge 3 commits into from

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 16, 2024

No description provided.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.31%. Comparing base (f7d263a) to head (77d37e6).

Files with missing lines Patch % Lines
...aem/analytics/model/ArticleAnalyticsScreenEvent.kt 0.00% 1 Missing ⚠️
.../godtools/article/aem/service/AemArticleManager.kt 50.00% 1 Missing ⚠️
...godtools/base/tool/ui/controller/BaseController.kt 0.00% 1 Missing ⚠️
...godtools/base/tool/ui/controller/TabsController.kt 0.00% 1 Missing ⚠️
...in/org/cru/godtools/base/tool/ui/util/BaseUtils.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3736   +/-   ##
========================================
  Coverage    39.31%   39.31%           
========================================
  Files          446      446           
  Lines        11243    11243           
  Branches      2495     2494    -1     
========================================
  Hits          4420     4420           
  Misses        6050     6050           
  Partials       773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett marked this pull request as draft October 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant