[187773038]: take out type information when updating NA

Crunch-io · Jun 12, 2024 · 9babe3e · 9babe3e
1 parent 538554d
commit 9babe3e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/R/variable-update.R b/R/variable-update.R
@@ -246,7 +246,7 @@ setMethod(
     function(x, i, j, value) {
         if (all(is.na(value))) {
             ## For assigning NA
-            value <- .no.data.value(type(x), add.type = TRUE)
+            value <- .no.data.value(type(x))
             if (has.categories(x)) {
                 return(.categorical.update[["numeric"]](x, i, j, value))
             }
@@ -266,14 +266,11 @@ setMethod(
     }
 )
 
-.no.data.value <- function(x, add.type = FALSE) {
+.no.data.value <- function(x) {
     if (has.categories(x)) {
         return(NA)
     } else {
-        out <- NA
-        if (add.type) {
-            out <- list(value = NA, type = list(class = x))
-        }
+        out <- list(value = NA)
         return(out)
     }
 }

diff --git a/tests/testthat/test-update-with-missing.R b/tests/testthat/test-update-with-missing.R
@@ -27,8 +27,8 @@ with_mock_crunch({
         expect_POST(
             is.na(ds$birthyr) <- ds$birthyr > 2016,
             "https://app.crunch.io/api/datasets/1/table/", '{"command":"update","variables":',
-            '{"https://app.crunch.io/api/datasets/1/variables/birthyr/":{"value":null,',
-            '"type":{"class":"numeric"}}},"filter":{"function":">","args":',
+            '{"https://app.crunch.io/api/datasets/1/variables/birthyr/":{"value":null',
+            '}},"filter":{"function":">","args":',
             '[{"variable":"https://app.crunch.io/api/datasets/1/variables/birthyr/"},',
             '{"value":2016}]}}'
         )