Proceed with major upgrade when data directory lacks checksums #4306
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when a data directory is imported from an external system. Issue: PGO-619
benjaminjb
reviewed
Sep 30, 2025
|
|
||
| `section 'Step 3 of 7: Initializing new data directory...'`, | ||
| `PGDATA="${new_data}" "${new_bin}/initdb" --allow-group-access --data-checksums` + argEncryptionKeyCommand, | ||
| `PGDATA="${new_data}" "${new_bin}/initdb" --allow-group-access ${checksums:+--data-checksums}` + argEncryptionKeyCommand, |
There was a problem hiding this comment.
Ah, ok, if checksum == 0, we drop the --data-checksums flag.
Looks like this flag is enabled by default in PG 18: https://www.postgresql.org/docs/18/app-initdb.html#APP-INITDB-DATA-CHECKSUMS (but not in PG 17 or earlier -- according to the docs)
There was a problem hiding this comment.
🔧 Good find. I'll update this for PG 18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Data directories created by PostgresCluster have checksums enabled, so existing tests exercise the logic that invokes
initdbwith the--data-checksumsargument.Type of Changes:
What is the current behavior (link to any open issues here)?
A data directory without checksums enabled fails during
pg_upgrade.What is the new behavior (if this is a feature change)?
PGUpgrade can upgrade a data directory that does not have checksums enabled.
Other Information:
This can happen when a data directory is imported from an external system.
Issue: PGO-619