-
Notifications
You must be signed in to change notification settings - Fork 2
Resolve Vulnerabilities; Complete code coverage; Update/Deduplicate dependencies #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to resolve security vulnerabilities by updating dependencies, improve test coverage to 100%, and deduplicate dependencies. However, there are critical issues with the implementation.
Changes:
- Increased Jest coverage thresholds from 95%/79% to 100% for all metrics (statements, branches, lines)
- Added comprehensive unit tests for edge cases including null/undefined stack responses and optional field handling
- Updated multiple development dependencies to newer versions (jest, @types/jest, prettier, typescript, eslint plugins)
- Updated @aws-sdk/client-cloudformation to ^3.972.0
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/unit/index.test.ts | Added 183 lines of new tests covering edge cases for null/undefined stack states, missing fields, and optional branches to achieve 100% code coverage |
| package.json | Updated coverage thresholds to 100%, upgraded multiple dependencies including jest, typescript, prettier, and AWS SDK |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
What does this PR do?
tarto resolve CVE-2026-23950 & CVE-2026-23745glob10.x -> 10.5.0 to resolve CVE-2025-64756js-yamlversions to resolve CVE-2025-64718Details
Why did you make this change? What does it affect?
Fix vulnerabilities
Better coverage is faster
Testing
How can the other reviewers check that your change works?
Tests will pass, 🟢 build will suffice.