Skip to content

workspace: add CODEOWNERS #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

workspace: add CODEOWNERS #331

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee72de1
add example CODEOWNERS
hinto-janai Oct 31, 2024
78e20a4
add codeowners
hinto-janai Oct 31, 2024
9382a92
add `SyntheticBird45` to `*`
hinto-janai Dec 3, 2024
d52597c
remove `/benches` https://github.com/Cuprate/cuprate/pull/354
hinto-janai Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# For `CODEOWNERS` documentation, see:
# <https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners>

# Default owner(s) of all code.
* @Boog900 @hinto-janai
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering matters, @Boog900 will appear at the top in the reviewers list and so-on.


# hinto-janai
/benches/** @hinto-janai
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last matching pattern takes the most precedence

In this case, changes to /benches will tag @hinto-janai first then everyone else (including everyone in *). I added myself for things I want to review.

Other notes:

  • Users listed here must have write access (I tried adding @dimalinux for cryptonight/ although it doesn't work)
  • @SyntheticBird45 I did not add you in * because every PR will tag you for review (and spam your email/notifications), did you want to be in this group or other paths/?

@Boog900 you need to enable the codeowner ruleset for main:

  1. Cuprate/cuprate Settings
  2. Code and automation
  3. Rulesets
  4. Require a pull request before merging
  5. Require review from Code Owners

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hinto-janai I'm already registered to any changes in the repository and receive mails accordingly. You can add me to it

/books/architecture/** @hinto-janai
/books/user/** @hinto-janai
/constants/** @hinto-janai
/rpc/** @hinto-janai
/storage/blockchain/** @hinto-janai
/storage/database/** @hinto-janai
/test-utils/data/** @hinto-janai
/test-utils/rpc/** @hinto-janai
Loading