lints: add #![forbid] lints per crate

Cargo.toml

@@ -377,6 +377,7 @@ unreachable_pub = "deny"
 unused_qualifications = "deny"
 variant_size_differences = "deny"
 non_camel_case_types = "deny"
+unsafe_code = "deny"
 
 # Hot
 # unused_results = "deny"

binaries/cuprated/src/main.rs

@@ -1,5 +1,9 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(docsrs, feature(doc_cfg))]
+#![forbid(
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 #![allow(
     unused_imports,
     unreachable_pub,

consensus/context/src/lib.rs

@@ -4,6 +4,13 @@
 //! This is used during contextual validation, this does not have all the data for contextual validation
 //! (outputs) for that you will need a [`Database`].
 
+#![forbid(
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 // Used in documentation references for [`BlockChainContextRequest`]
 // FIXME: should we pull in a dependency just to link docs?
 use monero_serai as _;

consensus/fast-sync/src/fast_sync.rs

@@ -41,13 +41,14 @@ fn max_height() -> u64 {
     (HASHES_OF_HASHES.len() * BATCH_SIZE) as u64
 }
 
-#[derive(Debug, PartialEq, Eq)]
+#[derive(Debug, PartialEq, Eq, Copy, Clone)]
 pub struct ValidBlockId(BlockId);
 
 fn valid_block_ids(block_ids: &[BlockId]) -> Vec<ValidBlockId> {
     block_ids.iter().map(|b| ValidBlockId(*b)).collect()
 }
 
+#[derive(Debug)]
 #[expect(clippy::large_enum_variant)]
 pub enum FastSyncRequest {
     ValidateHashes {
@@ -110,6 +111,7 @@ impl From<tower::BoxError> for FastSyncError {
     }
 }
 
+#[derive(Debug)]
 pub struct FastSyncService<C> {
     context_svc: C,
 }

consensus/fast-sync/src/lib.rs

@@ -1,3 +1,14 @@
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    unused_results,
+    missing_copy_implementations,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 // Used in `create.rs`
 use clap as _;
 use cuprate_blockchain as _;

consensus/rules/src/blocks.rs

@@ -210,7 +210,7 @@ fn check_txs_unique(txs: &[[u8; 32]]) -> Result<(), BlockError> {
 
 /// This struct contains the data needed to verify a block, implementers MUST make sure
 /// the data in this struct is calculated correctly.
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Copy)]
 pub struct ContextToVerifyBlock {
     /// ref: <https://monero-book.cuprate.org/consensus_rules/blocks/weights.html#median-weight-for-coinbase-checks>
     pub median_weight_for_block_reward: usize,

consensus/rules/src/lib.rs

@@ -1,3 +1,10 @@
+#![forbid(
+    unsafe_code,
+    missing_copy_implementations,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 cfg_if::cfg_if! {
     // Used in external `tests/`.
     if #[cfg(test)] {

consensus/src/lib.rs

@@ -11,6 +11,12 @@
 //! with [`BlockchainResponse`].
 //!
 
+#![forbid(
+    unsafe_code,
+    missing_copy_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 cfg_if::cfg_if! {
     // Used in external `tests/`.
     if #[cfg(test)] {

constants/src/lib.rs

@@ -1,5 +1,18 @@
 #![doc = include_str!("../README.md")]
-#![deny(missing_docs, reason = "all constants should document what they are")]
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_docs_in_private_items,
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    missing_docs,
+    unsafe_code,
+    unused_results,
+    missing_copy_implementations,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 #![no_std] // This can be removed if we eventually need `std`.
 
 mod macros;

constants/src/macros.rs

@@ -1,3 +1,5 @@
+//! General macros.
+
 /// Output a string link to `monerod` source code.
 #[allow(
     clippy::allow_attributes,

cryptonight/src/lib.rs

@@ -1,3 +1,14 @@
+#![forbid(
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    missing_copy_implementations,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 mod blake256;
 mod cnaes;
 mod hash_v2;
@@ -18,6 +29,7 @@ pub struct DataCanNotBeHashed;
 
 /// Calculates the `CryptoNight` v1 hash of buf.
 ///
+/// # Errors
 /// This will return an error if buf is less than 43 bytes.
 pub fn cryptonight_hash_v1(buf: &[u8]) -> Result<[u8; 32], DataCanNotBeHashed> {
     if buf.len() < 43 {

helper/src/lib.rs

@@ -1,5 +1,10 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(not(feature = "std"), no_std)]
+#![forbid(
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 
 //---------------------------------------------------------------------------------------------------- Public API
 #[cfg(feature = "asynch")]

helper/src/thread.rs

@@ -69,6 +69,7 @@ impl_thread_percent! {
 ///
 /// On macOS and *BSD: +20
 /// On Linux: +19
+#[expect(unsafe_code, reason = "Must call C")]
 pub fn low_priority_thread() {
     #[cfg(target_os = "windows")]
     {

net/epee-encoding/src/lib.rs

@@ -59,6 +59,13 @@
 //!
 //! ```
 
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 #[cfg(test)]
 use hex as _;
 

net/fixed-bytes/src/lib.rs

@@ -1,4 +1,14 @@
 #![doc = include_str!("../README.md")]
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 
 use core::{
     fmt::{Debug, Formatter},

net/levin/src/lib.rs

@@ -27,7 +27,13 @@
 //! This project is licensed under the MIT License.
 
 // Coding conventions
-#![forbid(unsafe_code)]
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    unsafe_code,
+    unused_results,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 #![deny(non_upper_case_globals)]
 #![deny(non_camel_case_types)]
 #![deny(unused_mut)]

net/wire/src/lib.rs

@@ -22,6 +22,14 @@
 //!
 //! This project is licensed under the MIT License.
 
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_panics_doc,
+    clippy::should_panic_without_expect,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 pub mod network_address;
 pub mod p2p;
 

p2p/address-book/src/lib.rs

@@ -10,6 +10,15 @@
 //! clear net peers getting linked to their dark counterparts
 //! and so peers will only get told about peers they can
 //! connect to.
+
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    missing_docs,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 use std::{io::ErrorKind, path::PathBuf, time::Duration};
 
 use cuprate_p2p_core::{NetZoneAddress, NetworkZone};

p2p/async-buffer/src/lib.rs

@@ -4,6 +4,15 @@
 //!
 //! Weight is used to bound the channel, on creation you specify a max weight and for each value you
 //! specify a weight.
+
+#![forbid(
+    clippy::missing_errors_doc,
+    clippy::should_panic_without_expect,
+    unsafe_code,
+    missing_copy_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 use std::{
     cmp::min,
     future::Future,

p2p/bucket/src/lib.rs

@@ -38,11 +38,23 @@
 //!
 //! ```
 
-use arrayvec::{ArrayVec, CapacityError};
-use rand::random;
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_docs_in_private_items,
+    clippy::missing_errors_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    missing_docs,
+    unsafe_code,
+    missing_copy_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 
 use std::{collections::BTreeMap, net::Ipv4Addr};
 
+use arrayvec::{ArrayVec, CapacityError};
+use rand::random;
+
 /// A discriminant that can be computed from the type.
 pub trait Bucketable: Sized + Eq + Clone {
     /// The type of the discriminant being used in the Binary tree.

p2p/dandelion-tower/src/lib.rs

@@ -58,6 +58,17 @@
 //! When removing data, for example because of a new block, you can remove from both pools provided it doesn't leak
 //! any data about stem transactions. You will probably want to set up a task that monitors the tx pool for stuck transactions,
 //! transactions that slipped in just as one was removed etc, this crate does not handle that.
+
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_errors_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    missing_copy_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 mod config;
 #[cfg(feature = "txpool")]
 pub mod pool;

p2p/p2p-core/src/lib.rs

@@ -57,6 +57,14 @@
 //! # });
 //! ```
 
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 cfg_if::cfg_if! {
     // Used in `tests/`
     if #[cfg(test)] {

p2p/p2p/src/lib.rs

@@ -2,6 +2,16 @@
 //!
 //! This crate contains a [`NetworkInterface`] which allows interacting with the Monero P2P network on
 //! a certain [`NetworkZone`]
+
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_errors_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 use std::sync::Arc;
 
 use futures::FutureExt;

pruning/src/lib.rs

@@ -18,6 +18,16 @@
 //! ```
 //!
 
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    unsafe_code,
+    unused_results,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
+
 use std::cmp::Ordering;
 
 use cuprate_constants::block::MAX_BLOCK_HEIGHT_USIZE;

rpc/interface/src/lib.rs

@@ -1,5 +1,19 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(docsrs, feature(doc_cfg))]
+#![forbid(
+    clippy::missing_assert_message,
+    clippy::missing_docs_in_private_items,
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::should_panic_without_expect,
+    clippy::single_char_lifetime_names,
+    missing_docs,
+    unsafe_code,
+    unused_results,
+    missing_copy_implementations,
+    missing_debug_implementations,
+    reason = "Crate-specific lints. There should be good reasoning when removing these."
+)]
 
 mod route;
 mod router_builder;

rpc/interface/src/router_builder.rs

@@ -69,7 +69,7 @@ macro_rules! generate_router_builder {
         ///     .all()
         ///     .build();
         /// ```
-        #[derive(Clone)]
+        #[derive(Debug, Clone)]
         pub struct RouterBuilder<H: RpcHandler> {
             router: Router<H>,
         }

rpc/interface/src/rpc_handler_dummy.rs

@@ -28,7 +28,7 @@ use crate::rpc_handler::RpcHandler;
 ///
 /// This is mostly used for testing purposes and can
 /// be disabled by disable the `dummy` feature flag.
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Deserialize, Serialize))]
 pub struct RpcHandlerDummy {
     /// Should this RPC server be [restricted](RpcHandler::restricted)?