Skip to content

Gp dlgs+gsn#138

Merged
DLLarson merged 11 commits intoCyberBoardPBEM:masterfrom
wsu-cb:gp-dlgs+gsn
Sep 14, 2025
Merged

Gp dlgs+gsn#138
DLLarson merged 11 commits intoCyberBoardPBEM:masterfrom
wsu-cb:gp-dlgs+gsn

Conversation

@wsu-cb
Copy link
Contributor

@wsu-cb wsu-cb commented Aug 16, 2025

No description provided.

wsu-cb added 11 commits August 8, 2025 13:06
WM_SHOWPLAYINGBOARD and WM_WINSTATE_RESTORE
MFC manages doc/frame/view objects, so split CGsnProjView into a
parent window that MFC can manage and a child window that has the
main implementation.  That way we can convert the main
implementation to wx while still letting MFC's doc/frame/view
code work.
@wsu-cb wsu-cb marked this pull request as ready for review August 17, 2025 22:47
@wsu-cb wsu-cb requested a review from DLLarson August 17, 2025 22:47
@DLLarson
Copy link
Member

Hi Bill,

Just a note to say I've seen the PR. A short one this time. I'll get through it soon.

-Dale

Copy link
Member

@DLLarson DLLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the smallest PR in a long while.

I see you're onto the CBPlay code now which is really great. I have nothing to call out in this PR.

However, the resource change that indicates that the app handles HighDPI processing should be changed to match CBDesign at some point sooner later to see what will break. I'll merge when you give the thumbs up.

Thanks!
-Dale

@wsu-cb
Copy link
Contributor Author

wsu-cb commented Sep 13, 2025

This is the smallest PR in a long while.

I see you're onto the CBPlay code now which is really great. I have nothing to call out in this PR.

However, the resource change that indicates that the app handles HighDPI processing should be changed to match CBDesign at some point sooner later to see what will break. I'll merge when you give the thumbs up.

Thanks! -Dale

I just noticed that this hasn't been merged.

@DLLarson
Copy link
Member

I'll merge when you give the thumbs up.

I'll take that as a "Thumbs up"? I usually want you're final say after the review.

-Dale

@wsu-cb
Copy link
Contributor Author

wsu-cb commented Sep 14, 2025

I'll take that as a "Thumbs up"? I usually want you're final say after the review.

Yes, please merge this. I actually did give "Thumbs up" reaction to #138 (review), but apparently reactions aren't reported by github, nor made a permanent part of the PR log the way, e.g., "Ready for review" is.

@DLLarson
Copy link
Member

but apparently reactions aren't reported by github, nor made a permanent part of the PR log the way, e.g., "Ready for review" is.

Ok... now that I look at the post I see the little thumbs up. I don't recall ever receiving a notice for it and I was watching for your response in my inbox.

Good to know.

Merging...

-Dale

@DLLarson DLLarson merged commit 170c9d3 into CyberBoardPBEM:master Sep 14, 2025
4 checks passed
@DLLarson
Copy link
Member

Merged. Sorry for the delay.

-Dale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants