Conversation
This reverts commit 3b41685.
WM_SHOWPLAYINGBOARD and WM_WINSTATE_RESTORE
MFC manages doc/frame/view objects, so split CGsnProjView into a parent window that MFC can manage and a child window that has the main implementation. That way we can convert the main implementation to wx while still letting MFC's doc/frame/view code work.
|
Hi Bill, Just a note to say I've seen the PR. A short one this time. I'll get through it soon. -Dale |
DLLarson
left a comment
There was a problem hiding this comment.
This is the smallest PR in a long while.
I see you're onto the CBPlay code now which is really great. I have nothing to call out in this PR.
However, the resource change that indicates that the app handles HighDPI processing should be changed to match CBDesign at some point sooner later to see what will break. I'll merge when you give the thumbs up.
Thanks!
-Dale
I just noticed that this hasn't been merged. |
I'll take that as a "Thumbs up"? I usually want you're final say after the review. -Dale |
Yes, please merge this. I actually did give "Thumbs up" reaction to #138 (review), but apparently reactions aren't reported by github, nor made a permanent part of the PR log the way, e.g., "Ready for review" is. |
Ok... now that I look at the post I see the little thumbs up. I don't recall ever receiving a notice for it and I was watching for your response in my inbox. Good to know. Merging... -Dale |
|
Merged. Sorry for the delay. -Dale |
No description provided.