fix bug where crawl_span (int of num days for crawl span) is overwritten with CrawlSpan object in run_repeated #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
macpd
commented
Jun 29, 2024
•
macpd
commented
- rename CrawlSpan -> CrawlDateWindow for clarity.
- do not overwrite crawl_span and assign CrawlDateWindow to new var crawl_date_window
…ten with CrawlSpan object in run_repeated. rename CrawlSpan -> CrawlDateSpan for clarity. do not overwrite crawl_span and assign CrawlDateSpan to new var crawl_date_span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.