Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add save/save as (aka overwrite) to sets action menu #146

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Jun 21, 2024

No description provided.

@x37v x37v requested a review from fde31 June 21, 2024 21:06
@fde31
Copy link
Member

fde31 commented Jun 22, 2024

Looks good to me. Just replaced the icon and adjusted the FAIcon usage to be using fixedWidth in when used in Menu.Item. Will follow up with a ticket to better handle the case of saving a new set with an already existing name which currently simply overwrites AFAIR

@x37v x37v merged commit 8c03763 into develop Jun 22, 2024
1 check passed
@x37v x37v deleted the feature/set-save branch June 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants