Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/conan #197

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Feature/conan #197

merged 5 commits into from
Feb 20, 2025
+105 −33

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Feb 18, 2025

automating conan packaging
need to test the github workflow

@x37v x37v requested a review from fde31 February 18, 2025 00:48
fde31
fde31 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@fde31 fde31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if the set_version in the conan recipe can be skipped but maybe it can given the tag via the conan cli. Otherwise looks good to me

@x37v
Copy link
Contributor Author

x37v commented Feb 20, 2025

IDK if the set_version in the conan recipe can be skipped but maybe it can given the tag via the conan cli. Otherwise looks good to me

yeah, the version can come on the commandline as well as the tag, since i'm setting those both in a script it didn't seem worth doing the work to also set them in python

@x37v x37v merged commit 5002ff9 into develop Feb 20, 2025
1 check passed
@x37v x37v deleted the feature/conan branch February 20, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fde31 fde31 fde31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x37v @fde31