Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Enum based on the spec for acknoledgement #579

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

mr-zepol
Copy link
Contributor

This adds an Enum for acknowledgement for licenses, this is to avoid issues when parsing and serializing, so it complies with the spec.

@mr-zepol mr-zepol requested a review from a team as a code owner December 18, 2024 14:09
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% 75.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0a6732e) 6370 4758 74.69%
Head commit (d1dd865) 6384 (+14) 4767 (+9) 74.67% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#579) 20 15 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro added the enhancement New feature or request label Dec 21, 2024
@nscuro nscuro merged commit 4fbdc6b into master Dec 21, 2024
11 checks passed
@nscuro nscuro deleted the add_enum_ack branch December 21, 2024 13:33
@nscuro nscuro added this to the 10.0.1 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants