feat(registry): add AES-SIV AEAD variant (RFC 5297)#764
feat(registry): add AES-SIV AEAD variant (RFC 5297)#764Mehrn0ush wants to merge 1 commit intoCycloneDX:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds AES-SIV (Synthetic Initialization Vector) as a new AEAD variant to the cryptography registry, addressing issue #763. AES-SIV is defined in RFC 5297 and provides deterministic authenticated encryption with associated data (AEAD).
Changes:
- Adds AES-SIV variant with support for 128, 192, and 256-bit key sizes
- Includes authoritative RFC 5297 standard reference with DOI URL
- Classified as an authenticated encryption (
ae) primitive within the AES algorithm family
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fixed — normalized to RFC5297 for consistency across the registry. |
|
Thanks again for the PR. Once merge conflicts are resolved, I can go ahead and merge this in. Thanks again. |
d352aeb to
05807bd
Compare
|
Conflicts are now resolved and the branch has been rebased onto the latest upstream/master. AES-SIV (RFC5297) is correctly registered under the AES AEAD family and RFC naming has been normalized for consistency. DCO sign-off is preserved. Thanks again for the review. |
05807bd to
5c20334
Compare
| "url": "https://doi.org/10.17487/RFC5297" | ||
| } | ||
| ], | ||
| "pattern": "AES[-(128|192|256)]-CTR-HMAC-SHA1[-96]", |
There was a problem hiding this comment.
This now seems to replace the AES-CTR-HMAC-SHA1.
Is this intended? looks like an artefact after the merge conflict.
There was a problem hiding this comment.
Not intended. During the rebase, the patch for AES-SIV was incorrectly applied on top of the existing AES-CTR-HMAC-SHA1 entry (RFC3686), which made it look like a replacement. I’ve fixed the conflict resolution to keep AES-CTR-HMAC-SHA1 intact and add AES-SIV (RFC 5297) as a separate ae variant under the AES family.
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
5c20334 to
0c16394
Compare
As discussed in ticket #763, this PR adds AES-SIV (RFC 5297) as an AEAD variant to the Cryptography Registry.
Fixes #763
Details
AES[-(128|192|256)]-SIVas anaevariant under the existingAESfamily.schema/cryptography-defs.json). No schema or specification behavior changes.